Fixed compiler incompatibility with Windows #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parser now checks for OS to select which file separator to use when extracting filenames. '\' for Windows, '/' for everything else, this fixes the issue in which the compiler didn't work on Windows systems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a major issue that made Dendry incompatible with Windows systems.
Checklist
The new code additions passed the tests ((I'm unable to run the tests, because the testing tool seems to be broken and puts out syntax errors no matter the system I use. However, the change is so small that it really shouldn't break anything.)npm test).Description
Unlike Mac or Linux, Windows uses '\' as the file separator. As dry.js relied on finding the character '/' to extract the filename from the given path, it was unable to parse Windows file paths and failed to compile.
The parser now checks for platform to select the correct file separator. This fixed the issue in all systems I tested, including with WSL.