Small stuff #2

humdingerb · 2024-02-20T15:57:00Z

Accept files dropped on the CommandsWindow
Add an "Edit" button that opens a command script in the editor
Update user guide

augiedoggie

Thanks for working on it! I need to add a better way to get the path from the command string for this as well as the icon lookup code.

augiedoggie · 2024-02-20T21:12:14Z

Source/CommandsWindow.cpp

 						.AddGlue()
+						.Add(fEditButton = new BButton("Edit" B_UTF8_ELLIPSIS, new BMessage(kEditCommandAction)))
 					.End()


I'm still debating about the text of the button. It might be better to be more explicit and say "Edit file". We can probably leave it like this for now until I get around to adding translation support.

What do you think about icon buttons. A folder icon for the "Browse" and a text icon + pen for the "Edit"?
Those could be put to the right of the BTextControl which would free up the space below as a positive side-effect.

I'm not against having icons but I was more concerned about making it clear that the file would be opened, instead of opening an editor that could be used to edit the current command line arguments. Maybe I'm overthinking it or not giving the users enough credit.

Not sure it's really a problem. I think the user will click on the icon and sees what happens and will know now what it exactly does. It's non-destructive, so nothing can really go wrong. Plus we can add a tooltip.

augiedoggie · 2024-02-20T21:22:30Z

Source/CommandsWindow.cpp

+void
+CommandsWindow::_EditCommand()
+{
+	if (_CommandIsScript()) {
+		const char* argv[] = { fCommandControl->Text(), NULL };
+		be_roster->Launch("text/x-source-code", 1, argv);
+	}
+}
+
+
+bool
+CommandsWindow::_CommandIsScript()
+{
+	BPath path = fCommandControl->Text();
+	if (path.InitCheck() != B_OK)
+		return false;
+
+	char mimeType[B_MIME_TYPE_LENGTH];
+	BNode commandNode(path.Path());
+	BNodeInfo(&commandNode).GetType(mimeType);
+	if (strncmp("text/", mimeType, 5) == 0)
+		return true;
+
+	return false;
+}
+


This is going to cause a problem if fCommandControl has shell escapes/quotes in the command or command line arguments. For example, if the command was /boot/home/myscript.sh --myarg then it would need to have the --myarg removed. I have some really ugly and crude code at

TrackRunner/Source/RunnerAddOn.cpp

Line 191 in 0268125

// attempt to find the actual file by splitting the command/arguments at the spaces

that could be moved to its own function and reused but I'd like to find a more reliable way to extract just the file path from the whole command string.

Haven't thought about that...
It'd be easiest and probably most robust to split that in two BTextControls:

Command/Script: /boot/home/myscript.sh Arguments: --myarg 5038 --myarg2 etc.

Or do you deem that too crude... :)

Certainly I've thought about splitting it up, and I may end up doing that eventually, but I was really avoiding doing that because I think it makes the user interface more cumbersome to use. Much easier to see or type out a whole command in one input box. I'll have to think about it to see if there are any other consequences of changing it.

One problem is going to be migrating existing users to the new system. It would be difficult to automatically convert the old commands to the split version.

True. Good luck with your command/argument parse&split then... :)

humdingerb · 2024-02-21T16:31:45Z

I'm currently having the hardest time with script filename with a space. The path needs to be escaped when actually running the command, but deescaped when launching the script for editing in a text editor (_EditCommand()) and checking if to enable the edit button (_CommandIsScript()).
It's all working well, and I see the correctly deescaped paths when using printf(). (_CommandIsScript() works, but the actual launching of the text editor fails (_EditCommand()).

I'll keep at it for a bit...
Also update the PR with that, in case you see the obvious. The PR as is won't be merged yet anyway, because the commandline parsing to get the pure command without arguments needs to be working first.

humdingerb · 2024-02-21T16:44:59Z

Quick question: I'm only used to our simple makefile_engine makefiles. How can I build a debug version with cmake?

augiedoggie · 2024-02-21T16:45:36Z

I'm currently having the hardest time with script filename with a space. The path needs to be escaped when actually running the command, but deescaped when launching the script for editing in a text editor (_EditCommand()) and checking if to enable the edit button (_CommandIsScript()).

Unfortunately this is only one of many possible variations. It doesn't necessarily even have to do with spaces. I could quote a command like '/boot/home/myscript.sh' --foo and now I have to check to see if the quotes should be removed.

augiedoggie · 2024-02-21T16:46:26Z

Quick question: I'm only used to our simple makefile_engine makefiles. How can I build a debug version with cmake?

cmake -DCMAKE_BUILD_TYPE=Debug should do it.

humdingerb · 2024-02-21T16:57:35Z

thanks!

augiedoggie · 2024-02-21T17:15:54Z

It seems like someone has probably created a regular expression to do the splitting and that's probably the most reliable way to do it. A quick search kept giving me results for splitting inside of bash but that's not what I want. I'll have to do a more thorough search when I get time.

humdingerb · 2024-02-22T07:06:57Z

JFYI, "Edit file..." now works with spaces in filenames. I'm unsure why, but it does after changing

	const char* argv[] = { fCommandControl->Text(), NULL };
	be_roster->Launch("text/x-source-code", 1, argv);

to

	BString file = _Deescape(fCommandControl->Text());
	const char* argv[] = { file.String(), NULL };
	be_roster->Launch("text/x-source-code", 1, argv);

augiedoggie · 2024-02-22T07:31:55Z

It doesn't look like it handles command line arguments though. I can probably come up with other examples that won't get parsed properly and I'd like to have the button working more reliably before it gets put into the app.

humdingerb · 2024-02-22T08:33:39Z

Correct. Once you've solved the hard problem of parsing out the command/script from the arguments - :) - it should be easy to provide _CommandIsScript() and _EditCommand() with the correct path.

augiedoggie · 2024-04-07T16:43:39Z

I haven't forgotten about this but I'm still undecided about the edit button. If you want to split the DnD part into a separate PR then I'll merge it.

humdingerb · 2024-04-08T06:28:00Z

OK, moved the d'n'd to #5.

augiedoggie · 2024-06-14T22:04:18Z

After more thinking, I would probably prefer having a "Show in Tracker" button instead of "Edit File". Once it's clicked and the file is shown in Tracker then the user could edit/rename/copy/whatever...

Would this be something that you want to work on?

* _CommandIsScript() simply checks if the command's path is valid and points to a text file. * _ShowCommand() opens the current script's location in Tracker and selects it. * Only enable the "Show in Tracker" button, if the command is a text file. It stays disabled, e.g. for a simple CLI command like /bin/ls.

* Mention the new "Show in Tracker" button and drag'n'drop of a script file to set the command. * Updated screenshot. * Optimized all PNGs.

humdingerb · 2024-06-15T09:20:04Z

Yes. As it happens, I worked on something similar to "Show in Tracker" for Genio recently. I could therefore very easily adopt that code. :)
I've updated the PR accordingly.

Source/CommandsWindow.cpp

augiedoggie · 2024-06-16T02:59:38Z

Nice. Thanks for working on it. I'll try to find some time to put out a new release.

humdingerb · 2024-06-16T08:44:03Z

Very good!
If you're interested in putting up the app at Polyglot, I opened #6.

augiedoggie reviewed Feb 20, 2024

View reviewed changes

humdingerb force-pushed the smallstuff branch from a8f29f9 to 096e741 Compare February 21, 2024 16:31

humdingerb force-pushed the smallstuff branch from 096e741 to c05fe36 Compare February 22, 2024 07:03

humdingerb force-pushed the smallstuff branch from c05fe36 to e0204f0 Compare February 22, 2024 07:07

humdingerb force-pushed the smallstuff branch from e0204f0 to 012cb29 Compare April 8, 2024 06:27

humdingerb added 2 commits June 15, 2024 11:00

Update user guide

34f9892

* Mention the new "Show in Tracker" button and drag'n'drop of a script file to set the command. * Updated screenshot. * Optimized all PNGs.

humdingerb force-pushed the smallstuff branch from 012cb29 to 34f9892 Compare June 15, 2024 09:18

augiedoggie reviewed Jun 16, 2024

View reviewed changes

Source/CommandsWindow.cpp Outdated Show resolved Hide resolved

Update Source/CommandsWindow.cpp

8c8d5ce

augiedoggie merged commit 9eef830 into augiedoggie:main Jun 16, 2024
2 checks passed

humdingerb deleted the smallstuff branch June 16, 2024 08:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Small stuff #2

Small stuff #2

humdingerb commented Feb 20, 2024

augiedoggie left a comment

augiedoggie Feb 20, 2024

humdingerb Feb 21, 2024

augiedoggie Feb 21, 2024

humdingerb Feb 21, 2024

augiedoggie Feb 20, 2024

humdingerb Feb 21, 2024

augiedoggie Feb 21, 2024

augiedoggie Feb 21, 2024

humdingerb Feb 21, 2024

humdingerb commented Feb 21, 2024

humdingerb commented Feb 21, 2024

augiedoggie commented Feb 21, 2024 •

edited

Loading

augiedoggie commented Feb 21, 2024

humdingerb commented Feb 21, 2024

augiedoggie commented Feb 21, 2024

humdingerb commented Feb 22, 2024

augiedoggie commented Feb 22, 2024

humdingerb commented Feb 22, 2024

augiedoggie commented Apr 7, 2024

humdingerb commented Apr 8, 2024

augiedoggie commented Jun 14, 2024

humdingerb commented Jun 15, 2024

augiedoggie commented Jun 16, 2024

humdingerb commented Jun 16, 2024

Small stuff #2

Small stuff #2

Conversation

humdingerb commented Feb 20, 2024

augiedoggie left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

humdingerb commented Feb 21, 2024

humdingerb commented Feb 21, 2024

augiedoggie commented Feb 21, 2024 • edited Loading

augiedoggie commented Feb 21, 2024

humdingerb commented Feb 21, 2024

augiedoggie commented Feb 21, 2024

humdingerb commented Feb 22, 2024

augiedoggie commented Feb 22, 2024

humdingerb commented Feb 22, 2024

augiedoggie commented Apr 7, 2024

humdingerb commented Apr 8, 2024

augiedoggie commented Jun 14, 2024

humdingerb commented Jun 15, 2024

augiedoggie commented Jun 16, 2024

humdingerb commented Jun 16, 2024

augiedoggie commented Feb 21, 2024 •

edited

Loading