feat: switch compute-node registration to SIWE wallet flow and drop NODE_URL#119
Merged
tatiesmars merged 3 commits intomainfrom Feb 12, 2026
Merged
feat: switch compute-node registration to SIWE wallet flow and drop NODE_URL#119tatiesmars merged 3 commits intomainfrom
tatiesmars merged 3 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the requirement for compute nodes to expose a public URL, migrating from callback-based registration to a wallet-based SIWE (Sign-In With Ethereum) authentication flow.
Changes:
- Replaced timestamp-based registration with SIWE message signing using EIP-191
- Removed
node_urlfield from configuration and registration requests - Added new cryptographic functions for Ethereum address derivation and EIP-191 signing
- Simplified registration loop by removing healthcheck callback logic
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| core/node-registration/src/register.rs | Replaced timestamp-based registration with SIWE flow; removed node_url parameter and healthcheck TTL logic |
| core/node-registration/src/crypto.rs | Added derive_eth_address and sign_eip191_recoverable_hex functions for Ethereum wallet operations |
| core/node-registration/README.md | Updated documentation to reflect SIWE-based registration and removed references to URL requirements |
| core/compute-node/tests/engine_dms_flow.rs | Removed node_url from test configurations |
| core/compute-node/tests/config_tests.rs | Updated tests to remove NODE_URL environment variable checks |
| core/compute-node/src/http.rs | Updated comments to clarify legacy nature of HTTP router |
| core/compute-node/src/engine.rs | Updated log message to remove reference to callback |
| core/compute-node/src/dds/register.rs | Removed node_url from registration settings and related logic |
| core/compute-node/src/config.rs | Removed NODE_URL environment variable requirement |
| core/compute-node/src/auth/siwe_after_registration.rs | Removed node_url from test configuration |
| core/compute-node/README.md | Updated documentation to reflect URL-less registration flow |
| core/compute-node-runner-api/examples/hello-runner/src/main.rs | Removed HTTP server setup code |
| core/compute-node-runner-api/examples/hello-runner/Cargo.toml | Removed axum dependency |
| core/compute-node-runner-api/examples/hello-runner/.env.example | Removed NODE_URL from environment example |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dataviruset
approved these changes
Jan 21, 2026
272b50d to
16aa848
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary