Skip to content

feat: switch compute-node registration to SIWE wallet flow and drop NODE_URL#119

Merged
tatiesmars merged 3 commits intomainfrom
feature/drop-public-url
Feb 12, 2026
Merged

feat: switch compute-node registration to SIWE wallet flow and drop NODE_URL#119
tatiesmars merged 3 commits intomainfrom
feature/drop-public-url

Conversation

@tatiesmars
Copy link
Contributor

@tatiesmars tatiesmars commented Jan 16, 2026

Summary

  • Remove the NODE_URL requirement from compute-node config and examples; inbound HTTP registration is now legacy-only.
  • Update node-registration to request SIWE metadata, build an EIP‑191 message, and register via /internal/v1/nodes/register-wallet using the derived wallet address.
  • Refresh registration on the configured interval, and simplify status handling (no healthcheck TTL).
  • Update README docs and tests to match the new SIWE wallet registration flow.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the requirement for compute nodes to expose a public URL, migrating from callback-based registration to a wallet-based SIWE (Sign-In With Ethereum) authentication flow.

Changes:

  • Replaced timestamp-based registration with SIWE message signing using EIP-191
  • Removed node_url field from configuration and registration requests
  • Added new cryptographic functions for Ethereum address derivation and EIP-191 signing
  • Simplified registration loop by removing healthcheck callback logic

Reviewed changes

Copilot reviewed 14 out of 15 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
core/node-registration/src/register.rs Replaced timestamp-based registration with SIWE flow; removed node_url parameter and healthcheck TTL logic
core/node-registration/src/crypto.rs Added derive_eth_address and sign_eip191_recoverable_hex functions for Ethereum wallet operations
core/node-registration/README.md Updated documentation to reflect SIWE-based registration and removed references to URL requirements
core/compute-node/tests/engine_dms_flow.rs Removed node_url from test configurations
core/compute-node/tests/config_tests.rs Updated tests to remove NODE_URL environment variable checks
core/compute-node/src/http.rs Updated comments to clarify legacy nature of HTTP router
core/compute-node/src/engine.rs Updated log message to remove reference to callback
core/compute-node/src/dds/register.rs Removed node_url from registration settings and related logic
core/compute-node/src/config.rs Removed NODE_URL environment variable requirement
core/compute-node/src/auth/siwe_after_registration.rs Removed node_url from test configuration
core/compute-node/README.md Updated documentation to reflect URL-less registration flow
core/compute-node-runner-api/examples/hello-runner/src/main.rs Removed HTTP server setup code
core/compute-node-runner-api/examples/hello-runner/Cargo.toml Removed axum dependency
core/compute-node-runner-api/examples/hello-runner/.env.example Removed NODE_URL from environment example

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tatiesmars tatiesmars changed the title feat: drop public url for compute-node feat: switch compute-node registration to SIWE wallet flow and drop NODE_URL Jan 19, 2026
@tatiesmars tatiesmars force-pushed the feature/drop-public-url branch from 272b50d to 16aa848 Compare February 12, 2026 04:30
@tatiesmars tatiesmars merged commit 5aa3be3 into main Feb 12, 2026
6 checks passed
@tatiesmars tatiesmars deleted the feature/drop-public-url branch February 12, 2026 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants