feat: remove the need for nodes to have public URLs#29
Conversation
chore: update doc
There was a problem hiding this comment.
Pull request overview
This PR removes the requirement for reconstruction nodes to have public URLs by eliminating the NODE_URL environment variable. This simplifies deployment and improves scalability by removing the need for 1-to-1 mappings between servers and ingresses.
Changes:
- Hardcoded
reconstruction_server_urltoNonein both local and global reconstruction runners - Removed
NODE_URLenvironment variable from documentation and configuration files - Eliminated port 8080 exposure requirements and associated ingress setup instructions
Reviewed changes
Copilot reviewed 6 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| server/rust/runner-reconstruction-local/src/lib.rs | Set reconstruction_server_url to None instead of reading from NODE_URL env var |
| server/rust/runner-reconstruction-global/src/lib.rs | Set reconstruction_server_url to None instead of reading from NODE_URL env var |
| server/rust/README.md | Removed NODE_URL setup instructions and health endpoint verification steps |
| server/rust/Makefile | Removed NODE_URL environment variable from run configuration |
| docs/deployment.md | Removed ngrok setup, port exposure requirements, and NODE_URL configuration |
| README.MD | Removed NODE_URL from environment file and ngrok setup instructions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
robinlindh
left a comment
There was a problem hiding this comment.
I tried running it and it worked well, even without port. Just pushed also to remove the ngrok troubleshooting text. Rest looks good to me.
|
Ahhh @tatiesmars we also need to update the minimum-requirements.md to not require public URL anymore. |
Makes the reconstruction-server easier to scale as servers don't need to have a 1-to-1 mapping to ingresses etc.