Skip to content

Comments

feat: remove the need for nodes to have public URLs#29

Merged
tatiesmars merged 4 commits intodevelopfrom
feature/drop-public-url
Feb 12, 2026
Merged

feat: remove the need for nodes to have public URLs#29
tatiesmars merged 4 commits intodevelopfrom
feature/drop-public-url

Conversation

@tatiesmars
Copy link
Contributor

@tatiesmars tatiesmars commented Jan 20, 2026

Makes the reconstruction-server easier to scale as servers don't need to have a 1-to-1 mapping to ingresses etc.

@dataviruset dataviruset changed the title feature: drop public url feat: drop public url Jan 21, 2026
@dataviruset dataviruset changed the title feat: drop public url feat: remove the need for nodes to have public URLs Jan 21, 2026
@dataviruset dataviruset requested a review from Copilot January 21, 2026 09:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the requirement for reconstruction nodes to have public URLs by eliminating the NODE_URL environment variable. This simplifies deployment and improves scalability by removing the need for 1-to-1 mappings between servers and ingresses.

Changes:

  • Hardcoded reconstruction_server_url to None in both local and global reconstruction runners
  • Removed NODE_URL environment variable from documentation and configuration files
  • Eliminated port 8080 exposure requirements and associated ingress setup instructions

Reviewed changes

Copilot reviewed 6 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
server/rust/runner-reconstruction-local/src/lib.rs Set reconstruction_server_url to None instead of reading from NODE_URL env var
server/rust/runner-reconstruction-global/src/lib.rs Set reconstruction_server_url to None instead of reading from NODE_URL env var
server/rust/README.md Removed NODE_URL setup instructions and health endpoint verification steps
server/rust/Makefile Removed NODE_URL environment variable from run configuration
docs/deployment.md Removed ngrok setup, port exposure requirements, and NODE_URL configuration
README.MD Removed NODE_URL from environment file and ngrok setup instructions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Collaborator

@robinlindh robinlindh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried running it and it worked well, even without port. Just pushed also to remove the ngrok troubleshooting text. Rest looks good to me.

@robinlindh
Copy link
Collaborator

Ahhh @tatiesmars we also need to update the minimum-requirements.md to not require public URL anymore.

@tatiesmars tatiesmars merged commit 060d712 into develop Feb 12, 2026
2 checks passed
@tatiesmars tatiesmars deleted the feature/drop-public-url branch February 12, 2026 05:51
@tatiesmars tatiesmars mentioned this pull request Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants