Merged
Conversation
dataviruset
requested changes
Jan 23, 2026
Co-authored-by: Oskar <oskar@aukilabs.com>
Co-authored-by: Oskar <oskar@aukilabs.com>
Co-authored-by: Oskar <oskar@aukilabs.com>
Co-authored-by: Oskar <oskar@aukilabs.com>
3964941 to
28793bd
Compare
dataviruset
approved these changes
Jan 26, 2026
Collaborator
|
Can we build locally without specifying this still? If not update deployment docs too. Or is this just for ci? We also have the version in python that ci replaces which ends up in the refined manifest. Currently both places in ci just pass in the git tag so it will be the same for now |
Contributor
If you build locally, it would be empty because there's no default provided. Or if you use |
robinlindh
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make compute-node versioning immutable at runtime by enforcing
RECONSTRUCTION_VERSIONat build time and removingNODE_VERSIONas a deploy-time override mechanism.Why
We want DDS registration to always reflect the version set by CI/tag builds, and prevent accidental or manual runtime overrides via container env vars.
What changed
server/rust/bin:RECONSTRUCTION_VERSIONat compile time.vX.Y.ZorX.Y.Z.v).RECONSTRUCTION_NODE_VERSION.bin/src/main.rsto forcecfg.node_versionfrom compile-timeRECONSTRUCTION_NODE_VERSION(not runtime env).semveras abuild-dependencyinserver/rust/bin/Cargo.tomland updatedCargo.lock.RECONSTRUCTION_VERSIONinto the Rust builder stage.ENV NODE_VERSION=...from Docker images.RECONSTRUCTION_VERSION=0.0.0+${{ github.sha }}Behavior change
NODE_VERSIONcan no longer be used to override DDS-registered node version at runtime.RECONSTRUCTION_VERSION.