-
Notifications
You must be signed in to change notification settings - Fork 252
feat: Allow Pydantic V2+ #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This wouldn't necessarily close #77 but is related to it. Also, for some reason the pytests passed but it couldn't upload it to codecov (which caused the check to fail). I've never used that service so I have no idea how to fix that, but keep that in mind. |
Thanks @kdcokenny we will take a look at both pydantic compatibility with v1 and v2, and codecov issue |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #109 +/- ##
=======================================
Coverage 91.25% 91.25%
=======================================
Files 25 25
Lines 1086 1086
=======================================
Hits 991 991
Misses 95 95 ☔ View full report in Codecov by Sentry. |
@kdcokenny thanks for another pr! Tests seem to be passing, but I'm seeing ValidationError when trying to run myself |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noted above
edit: testing further, may be an issue with my env, will update soon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kdcokenny I triple checked — all looks great, thanks for the awesome PR!
For this, I followed this Pydantic Migration Guide and it showed me a quick and easy way to temporarily (though probably not best practice) to allow me and others to use pydantic 2+ with semantic router.
It passes all tests so I assume it would work well while we wait for a more official pydantic v2 migration.
Lmk what you all think.