Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: created fastembed and hybrid dependency groups #81

Merged
merged 3 commits into from
Jan 6, 2024

Conversation

jamescalam
Copy link
Member

@jamescalam jamescalam commented Jan 6, 2024

Fixes #80
Removed fastembed and pinecone-text from the default dependencies and created two dependency groups, [fastembed] and [hybrid]. Installed with:

  • fastembed: pip install "semantic-router[fastembed]" or on local pip install ".[fastembed]"
  • hybrid: pip install "semantic-router[hybrid]" or on local pip install ".[hybrid]" (note: this is required for HybridRouteLayer

@jamescalam jamescalam added the enhancement Enhancement to existing features label Jan 6, 2024
@jamescalam jamescalam requested a review from ashraq1455 January 6, 2024 15:33
Copy link

codecov bot commented Jan 6, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (1fc9df9) 88.31% compared to head (5006b49) 87.77%.

Files Patch % Lines
semantic_router/encoders/bm25.py 50.00% 2 Missing ⚠️
semantic_router/layer.py 50.00% 2 Missing ⚠️
semantic_router/schema.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
- Coverage   88.31%   87.77%   -0.55%     
==========================================
  Files          16       16              
  Lines         676      687      +11     
==========================================
+ Hits          597      603       +6     
- Misses         79       84       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamescalam jamescalam merged commit 16ebc93 into main Jan 6, 2024
4 of 6 checks passed
@jamescalam
Copy link
Member Author

Merging, opening issue and another PR for codecov fix

@jamescalam jamescalam deleted the james/dependency-groups branch January 6, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dependency groups
2 participants