Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Typing hints #83

Closed
wants to merge 4 commits into from
Closed

Conversation

hananell
Copy link
Contributor

@hananell hananell commented Jan 7, 2024

Standardize hint style: always use list instead of typing.List
Make sure all functions have an output tying hint

@jamescalam jamescalam changed the title Typing hints fix: Typing hints Jan 7, 2024
Copy link

codecov bot commented Jan 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (99ce319) 87.08% compared to head (ea251e1) 87.10%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
+ Coverage   87.08%   87.10%   +0.01%     
==========================================
  Files          21       21              
  Lines         813      814       +1     
==========================================
+ Hits          708      709       +1     
  Misses        105      105              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamescalam
Copy link
Member

Looks good @hananell! I ran black linter for you — you can also do it locally by running make lint (to view issues) and make format (to fix issues) in the future.

The linters are picking up on a couple of issues (looks like the ruff linter), again, you can check locally with make lint or check out the failing action above. If we can get those fixed we can merge, thanks!

@jamescalam jamescalam self-requested a review January 7, 2024 16:21
@hananell hananell closed this Jan 11, 2024
@hananell hananell deleted the typing_hints branch January 11, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants