Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add HuggingFace Encoder #90

Merged
merged 11 commits into from
Jan 9, 2024
Merged

feat: Add HuggingFace Encoder #90

merged 11 commits into from
Jan 9, 2024

Conversation

ashraq1455
Copy link
Contributor

@ashraq1455 ashraq1455 commented Jan 8, 2024

No description provided.

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (c96769a) 87.08% compared to head (8c445ec) 87.64%.

Files Patch % Lines
semantic_router/encoders/huggingface.py 96.66% 2 Missing ⚠️
semantic_router/hybrid_layer.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
+ Coverage   87.08%   87.64%   +0.55%     
==========================================
  Files          21       22       +1     
  Lines         813      882      +69     
==========================================
+ Hits          708      773      +65     
- Misses        105      109       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamescalam jamescalam changed the title Add HuggingFace Encoder feat: Add HuggingFace Encoder Jan 8, 2024
@ashraq1455 ashraq1455 marked this pull request as ready for review January 9, 2024 10:58
@ashraq1455 ashraq1455 requested a review from jamescalam January 9, 2024 11:39
@bruvduroiu
Copy link
Member

Does this close #64 ?

Copy link
Member

@bruvduroiu bruvduroiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ashraq1455
Copy link
Contributor Author

Does this close #64 ?

@bruvduroiu this is only for embedding models

@jamescalam jamescalam merged commit f8fcd43 into main Jan 9, 2024
6 checks passed
@jamescalam
Copy link
Member

Thanks @ashraq1455 — I will mark #78 and #93 as complete

@jamescalam jamescalam deleted the ashraq/hf-encoder branch January 9, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants