Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP]Compatibility with Zotero v5 Standalone #17

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[WIP]Compatibility with Zotero v5 Standalone #17

wants to merge 5 commits into from

Conversation

zuphilip
Copy link
Collaborator

@zuphilip zuphilip commented Apr 27, 2018 •
edited
Loading

This is not yet working. When I try to install it in the Standalone then I see an error and Zotero logs:

[JavaScript Error: "formatURLPref: Couldn't get pref: extensions.getAddons.link.url" {file: "resource://gre/components/nsURLFormatter.js" line: 143}]
uf_formatURLPref@resource://gre/components/nsURLFormatter.js:143:7
gListView.initialize@chrome://mozapps/content/extensions/extensions.js:2735:9
gViewController.initialize@chrome://mozapps/content/extensions/extensions.js:709:7
initialize@chrome://mozapps/content/extensions/extensions.js:211:3


1524831508636	addons.xpi	WARN	Add-on z2csl@aurimas.vin is not compatible with application version.

1524831508645	addons.xpi	WARN	Add-on z2csl@aurimas.vin is not compatible with application version.

1524831792824	addons.xpi	WARN	Add-on z2csl@aurimas.vin is not compatible with application version.

1524831792833	addons.xpi	WARN	Add-on z2csl@aurimas.vin is not compatible with application version.

1524831942243	addons.xpi	WARN	Add-on z2csl@aurimas.vin is not compatible with application version.

1524831942254	addons.xpi	WARN	Add-on z2csl@aurimas.vin is not compatible with application version.

1524831984325	addons.xpi	WARN	Add-on z2csl@aurimas.vin is not compatible with application version.

1524831984332	addons.xpi	WARN	Add-on z2csl@aurimas.vin is not compatible with application version.

@adam3smith @dstillman Any ideas what is the problem here and how to fix it?

@zuphilip
Copy link
Collaborator Author

Okay, I could continue now. The main problem was that the build.sh script is not building from the current content but rather from the HEAD i.e. only checked in changes.

@zuphilip
Copy link
Collaborator Author

Now, I see new errors:

[JavaScript Error: "UnloadedDataException: Item type data not yet loaded"]

[JavaScript Error: "UnloadedDataException: Item type data not yet loaded"]

[JavaScript Error: "TypeError: this.zoteroTypes is undefined" {file: "chrome://z2csl/content/z2csl.js" line: 40}]
Zotero.Z2CSL.exportMappings@chrome://z2csl/content/z2csl.js:40:16
oncommand@chrome://zotero/content/standalone/standalone.xul:1:1

@zuphilip zuphilip mentioned this pull request May 23, 2018
Open
@zuphilip
Use zip instead of git archive in build.sh
a703a45 
It seems only possible to use git archive after
the changes are commited and this is not very
comfortable during developing. Therefore, changed
to zip instead.
@zuphilip
Updated overlay to menu_ToolsPopup
4966175
@zuphilip
Update url to CSL specification
777aaa2
@zuphilip
Move call to Zotero.ItemTypes outside init
8aa51b0 
When calling the init function then the Zotero object
is not yet loaded and therefore this line lead to
a undefined variable.

It was easier to move this line instead of using e.g.
```
await Zotero.Schema.schemaUpdatePromise
```
which lead to new problems.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zuphilip