Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed the trigger from pull_request_target to pull_request for better security #1297

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Changed the trigger from pull_request_target to pull_request for better security #1297

merged 1 commit into from
Sep 3, 2024

Conversation

gyaneshgouraw-okta
Copy link
Contributor

Changes

Made security related changes wrt. pull_request_target

  • Changed pull_request_target to pull_request pull_request
  • Removed the authorize job from the list of jobs defined in that workflow
  • Remove the dependency on authorize job for other jobs in that workflow

Checklist

@gyaneshgouraw-okta gyaneshgouraw-okta requested a review from a team as a code owner September 3, 2024 07:43
@gyaneshgouraw-okta gyaneshgouraw-okta merged commit 974b740 into main Sep 3, 2024
19 of 20 checks passed
@gyaneshgouraw-okta gyaneshgouraw-okta deleted the security/ci/browserstack_workflow branch September 3, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desusai7 desusai7 desusai7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gyaneshgouraw-okta @desusai7