Remove dependency on controller-runtime #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecordell
force-pushed
the
rmcr
branch
3 times, most recently
from
2e2e107
to
ee663c1
Compare
jzelinskie
reviewed
Aug 17, 2023
this also bumps to kube 1.28 dependencies to deal with: kubernetes/kubernetes#118340
jzelinskie
approved these changes
Aug 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/kubernetes-sigs/controller-runtime/blob/304027bcbe4b3f6d582180aec5759eb4db3f17fd/pkg/internal/testing/addr/manager.go#L44-L59
This init function always tries to write a file to /tmp on start. We don't want that to happen when using controller-idioms at runtime.
I removed the one place we use envtest and wrote a stripped down version that just does what we need for bootstrapping CRDs on controller start.
This also fixes #41 and gives us a place to start writing integration tests against a kind cluster. I added some basic
magecommands to make it easier to run tests.