Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support async traits #98

Merged
merged 1 commit into from
Feb 27, 2024
Merged

feat: support async traits #98

merged 1 commit into from
Feb 27, 2024

Conversation

makcandrov
Copy link
Contributor

This PR enables auto_impl to support async traits stabilized in version 1.75.
This implementation doesn't break the current usage with #[async_trait].

Refer to the test at tests/since_1.75/compile-pass/async_trait.rs for a test that currently fails but passes with this PR.

@makcandrov
Copy link
Contributor Author

@KodrAus

@KodrAus
Copy link
Member

KodrAus commented Feb 27, 2024

Thanks @makcandrov! This looks good to me.

@KodrAus KodrAus merged commit 99cff88 into auto-impl-rs:main Feb 27, 2024
4 checks passed
@KodrAus KodrAus mentioned this pull request Feb 27, 2024
montekki referenced this pull request in matter-labs/zksync-withdrawal-finalizer Feb 28, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [auto_impl](https://togithub.com/auto-impl-rs/auto_impl) |
workspace.dependencies | minor | `1.1.2` -> `1.2.0` |

---

### Release Notes

<details>
<summary>auto-impl-rs/auto_impl (auto_impl)</summary>

###
[`v1.2.0`](https://togithub.com/auto-impl-rs/auto_impl/releases/tag/v1.2.0)

[Compare
Source](https://togithub.com/auto-impl-rs/auto_impl/compare/v1.1.2...v1.2.0)

#### What's Changed

- feat: support async traits by
[@&#8203;makcandrov](https://togithub.com/makcandrov) in
[https://github.com/auto-impl-rs/auto_impl/pull/98](https://togithub.com/auto-impl-rs/auto_impl/pull/98)
- Prepare for 1.2.0 release by
[@&#8203;KodrAus](https://togithub.com/KodrAus) in
[https://github.com/auto-impl-rs/auto_impl/pull/99](https://togithub.com/auto-impl-rs/auto_impl/pull/99)

#### New Contributors

- [@&#8203;makcandrov](https://togithub.com/makcandrov) made their first
contribution in
[https://github.com/auto-impl-rs/auto_impl/pull/98](https://togithub.com/auto-impl-rs/auto_impl/pull/98)

**Full Changelog**:
auto-impl-rs/auto_impl@v1.1.2...v1.2.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/matter-labs/zksync-withdrawal-finalizer).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMTIuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIxMi4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants