Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/pages: add ChallengeInactivePage to show when no active challenge #629

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

maceksimon
Copy link
Contributor

@maceksimon maceksimon commented Oct 17, 2024

Add ChallengeInactivePage and define states "challenge active" and "challenge inactive".

New page:

  • 📄 Add new page ChallengeInactivePage.
  • 🧩 Add new component ChallengeInactiveInfo displaying info text.
  • 🌒 Add dark variant to ListCardPost so we can reuse it on the ChallengeInactivePage.
  • 🔘 Update button "All posts" in ListCardPost - linking to RTWBB blog.
  • 🧩 Add new component SocialBar for displaying links to social media on ChallengeInactivePage.
  • 🔧 Refactor the social links data into a fixture and add logic to build array in useSocialLinks composable.

New states:

  • 📦 Update challenge store with a getter for the isActiveChallenge state.
  • 🔀 Update router rules adding the isActiveChallenge state condition.
  • ✅ Update tests and add new tests for active and inactive states.
  • 🔧 In commonTests, add functions encapsulating common intercept sets for active and inactive states.
  • 📝 Add thisChallenge fixture with phase sets showing the challenge state.
  • 📝 Add fixtures to simulate logging in in different states. Includes renaming systemTime variables for different purposes:
    • systemTimeLoggedIn- testing logging in with a token (originally systemTime).
    • systemTimeChallengeActive + systemTimeChallengeInactive - testing challenge state.

@maceksimon maceksimon marked this pull request as draft October 17, 2024 20:18
@tmszi tmszi added the enhancement New feature or request label Oct 22, 2024
@maceksimon maceksimon force-pushed the feature/challenge-inactive-page branch from bb8f50f to 97147f1 Compare October 22, 2024 14:08
@maceksimon maceksimon marked this pull request as ready for review October 23, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants