Skip to content

Conversation

@RonenMars
Copy link
Contributor

Modified the Vite configuration to fix SSL certificate generation and server hosting when using a custom domain.

  • Removing the conditional SSL certificate setup
  • always enabling mkcert with both localhost and custom domain hosts
  • removing an ESLint disable comment
  • changing the server host from using the domain as a string to "0.0.0.0" for proper network binding.

What type of PR is this? (check all applicable)

  • 💡 (feat) - A new feature (non-breaking change which adds functionality)
  • 🔄 (refactor) - Code Refactoring - A code change that neither fixes a bug nor adds a feature
  • 🐞 (fix) - Bug Fix (non-breaking change which fixes an issue)
  • 🏎 (perf) - Optimization
  • 📄 (docs) - Documentation - Documentation only changes
  • 📄 (test) - Tests - Adding missing tests or correcting existing tests
  • ⚙️ (ci) - Continuous Integrations - Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
  • ☑️ (chore) - Chores - Other changes that don't modify src or test files
  • ↩️ (revert) - Reverts - Reverts a previous commit(s).

@RonenMars RonenMars force-pushed the ronen/fix/run-with-domain branch 2 times, most recently from 234a8d3 to f7a9493 Compare October 28, 2025 06:30
@RonenMars RonenMars force-pushed the ronen/fix/run-with-domain branch from f7a9493 to e7e6ee3 Compare October 28, 2025 07:39
@RonenMars RonenMars force-pushed the ronen/fix/run-with-domain branch from e498360 to c554fd4 Compare October 28, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants