Check for null object IDs #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjg
force-pushed
the
object-id-null-check
branch
from
312d97d
to
ff4ecf3
Compare
Problem: at various places in the rust codebase we receive an object ID from the java side in the form of a `jobject` which is a pointer to a `ObjectId`. This pointer can be null but we were not checking whether it was null and consequently were panicking and crashing the entire JVM. Solution: check for null when loading object IDs and throw an IllegalArgumentException if the `ObjectId` is null. This required a macro to avoid lots of code handling the early return.
alexjg
force-pushed
the
object-id-null-check
branch
from
ff4ecf3
to
0cf0130
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: at various places in the rust codebase we receive an object ID from the java side in the form of a
jobjectwhich is a pointer to aObjectId. This pointer can be null but we were not checking whether it was null and consequently were panicking and crashing the entire JVM.Solution: check for null when loading object IDs and throw an IllegalArgumentException if the
ObjectIdis null. This required a macro to avoid lots of code handling the early return.Fixes #4 (I think)