Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Made CrossValTypes, HoldoutValTypes to have split functions directly #108

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

[Refactor] Made CrossValTypes, HoldoutValTypes to have split functions directly #108

wants to merge 12 commits into from

Commits on May 19, 2021

  1. [refactor] Update the split functions to be able to call function dir… 

    …ectly
    @nabenabe0928
    nabenabe0928 committed May 19, 2021
    Configuration menu
    Copy the full SHA
    b803770 View commit details
    Browse the repository at this point in the history

  2. [feat] Deprecate shuffle inside BaseDataset and enable only in split … 

    …funcs
    @nabenabe0928
    nabenabe0928 committed May 19, 2021
    Configuration menu
    Copy the full SHA
    4d901f9 View commit details
    Browse the repository at this point in the history

  3. [fix] Fix flake8 and mypy issues

    @nabenabe0928
    nabenabe0928 committed May 19, 2021
    Configuration menu
    Copy the full SHA
    6c31f61 View commit details
    Browse the repository at this point in the history

  4. [fix] Fix mypy issues

    @nabenabe0928
    nabenabe0928 committed May 19, 2021
    Configuration menu
    Copy the full SHA
    b7d3531 View commit details
    Browse the repository at this point in the history

  5. [fix] Fix mypy issues and modify the test accordingly 

    Since the previous codes had the default shuffle = True and the indices
shuffle before splitting, the test cases for CV and Holdout did not match.
More specifically, when I bring back the followings, I could reproduce
the original outputs:
1. Bring back _get_indices in BaseDataset
2. Make the default value of self.shuffle in BaseDataset True
3. Input shuffle = True in KFold instead of using ShuffleSplit
These reproduce the original outputs.
Note that KFold(shuffle=True) and ShuffleSplit() are not identical
and even when we input the same random_state, the results do not reproduce.
    @nabenabe0928
    nabenabe0928 committed May 19, 2021
    Configuration menu
    Copy the full SHA
    eee3b1c View commit details
    Browse the repository at this point in the history

  6. [fix] Fix most test cases

    @nabenabe0928
    nabenabe0928 committed May 19, 2021
    Configuration menu
    Copy the full SHA
    910e7d4 View commit details
    Browse the repository at this point in the history

  7. [fix] Bring back the data generator shuffle

    @nabenabe0928
    nabenabe0928 committed May 19, 2021
    Configuration menu
    Copy the full SHA
    8c9b895 View commit details
    Browse the repository at this point in the history

  8. [fix] Fix the test value caused by putting back the shuffle generator

    @nabenabe0928
    nabenabe0928 committed May 19, 2021
    Configuration menu
    Copy the full SHA
    93e6862 View commit details
    Browse the repository at this point in the history

  9. [fix] Fix pytest errors

    @nabenabe0928
    nabenabe0928 committed May 19, 2021
    Configuration menu
    Copy the full SHA
    bef4323 View commit details
    Browse the repository at this point in the history

  10. [refactor] Change files so that we can see the difference easier

    @nabenabe0928
    nabenabe0928 committed May 19, 2021
    Configuration menu
    Copy the full SHA
    2d2ebb8 View commit details
    Browse the repository at this point in the history

  11. [refactor] Gether kwargs for get splits for CV and Holdout

    @nabenabe0928
    nabenabe0928 committed May 19, 2021
    Configuration menu
    Copy the full SHA
    8d90b85 View commit details
    Browse the repository at this point in the history

  12. [fix] Fix a mypy issue

    @nabenabe0928
    nabenabe0928 committed May 19, 2021
    Configuration menu
    Copy the full SHA
    6ef981d View commit details
    Browse the repository at this point in the history