Goals for CARL #97
Merged
Goals for CARL #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## development #97 +/- ##
================================================
+ Coverage 19.05% 44.61% +25.55%
================================================
Files 78 80 +2
Lines 4030 4198 +168
Branches 555 565 +10
================================================
+ Hits 768 1873 +1105
+ Misses 3224 2245 -979
- Partials 38 80 +42 |
benjamc
reviewed
Feb 9, 2024
benjamc
approved these changes
Feb 9, 2024
| self.context = None | ||
|
|
||
| def reset(self, seed=None, options={}): | ||
| print(self.context) |
There was a problem hiding this comment.
Ah, thought that was further up xD
| @@ -50,4 +55,13 @@ def get_context_features() -> dict[str, ContextFeature]: | |||
| "mass_ffoot": UniformFloatContextFeature( | |||
| "mass_ffoot", lower=1e-6, upper=np.inf, default_value=0.8845188 | |||
| ), | |||
| "target_distance": UniformFloatContextFeature( | |||
There was a problem hiding this comment.
default distance of 0? == no goals?
There was a problem hiding this comment.
Put 100 everywhere now. That made me notice something else, though: right now by default the envs will be goal envs, I think. We should probably change that...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
This will probably have some conflicts and should be merged last. Things to discuss: