Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for branch convergence #18

Open
wants to merge 82 commits into
base: master
Choose a base branch
from
Open

Update for branch convergence #18

wants to merge 82 commits into from

Conversation

vonHartz
Copy link
Collaborator

@vonHartz vonHartz commented Oct 20, 2021

For some additional details see discussion below.

Updates:

  • some autoformatting
  • added some mujoco-envs (walker2d, humanoid)
  • logging ray.init-kwargs
  • external ray init option
  • wandb logging option
  • patch for missing seq_len key: using default of 1
  • added generic env_wrapper
  • switched from dill to cloudpickle for saving ray analysis
  • added kwargs for ray init to arg parse
  • also returning stats_file name now
  • docs building, including doc of CLI options

@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #18 (2fb747d) into master (bfe2ea3) will decrease coverage by 0.32%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
- Coverage   72.66%   72.33%   -0.33%     
==========================================
  Files          30       30              
  Lines        3698     3745      +47     
==========================================
+ Hits         2687     2709      +22     
- Misses       1011     1036      +25     
Flag Coverage Δ
unittests 72.33% <ø> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mdp_playground/analysis/analysis.py 26.94% <ø> (ø)
...dp_playground/config_processor/config_processor.py 45.63% <ø> (-1.05%) ⬇️
mdp_playground/scripts/run_experiments.py 85.22% <ø> (-5.69%) ⬇️
setup.py 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfe2ea3...2fb747d. Read the comment docs.

Copy link
Collaborator Author

@vonHartz vonHartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some thoughts.

mdp_playground/scripts/run_experiments.py Outdated Show resolved Hide resolved
mdp_playground/scripts/run_experiments.py Show resolved Hide resolved
mdp_playground/scripts/run_experiments.py Outdated Show resolved Hide resolved
Copy link
Collaborator Author

@vonHartz vonHartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated code selection.

pyproject.toml Outdated Show resolved Hide resolved
@vonHartz
Copy link
Collaborator Author

All requested changes made. Ready to go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant