refactor: graph search space cleanup #137
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timurcarstensen
changed the title
|
Going to steal this PR into #134 where I also removed a bunch of code! Thanks you xx |
|
Heyo, thanks for this, now merged into #134 ... trying to keep an accurate timeline of handling merges/ rebasing is messy since it also includes ruff things so I just found it easier to shove into one PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the NePS architecture search space.
Essentially: I went through the NePS architecture search space codebase and removed everything that wasn't used anywhere. I also went and added some type hints here and there and tried to make ruff happy. There's still a lot of things ruff complains about and I haven't had the time to clean that up