Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated assertion on model support #36

Merged
merged 7 commits into from
Sep 20, 2024

Conversation

liam-sbhoo
Copy link
Collaborator

@liam-sbhoo liam-sbhoo commented Sep 14, 2024

Change Description

I think this assertion is outdated.

Addition / Fix:

  • TabPFNRegressor.list_available_models()
  • add model support
  • fix unnecessary welcoming message everytime we call fit.

I have tested it (checked from Vertex log, make sure the model specified in client is being used).

Try to be precise. You can additionally add comments to your PR, this might help the reviewer a lot.

If you used new dependencies: Did you add them to requirements.txt?

NO

Who did you ping on Mattermost to review your PR? Please ping that person again whenever you are ready for another review.

Breaking changes

If you made any breaking changes, please update the version number.
Breaking changes are totally fine, we just need to make sure to keep the users informed and the server in sync.

Does this PR break the API? If so, what is the corresponding server commit?

Does this PR break the user interface? If so, why?


Please do not mark comments/conversations as resolved unless you are the assigned reviewer. This helps maintain clarity during the review process.

Copy link
Collaborator

@SamuelGabriel SamuelGabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@SamuelGabriel SamuelGabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks nice, but for the one comment i left. please fix the name, then this is ready to be merged.

tabpfn_client/estimator.py Outdated Show resolved Hide resolved
@liam-sbhoo
Copy link
Collaborator Author

I renamed model_path to model (although some pre-processing required, TabPFN takes both model and model_path and they meant different things).
Added some test case too.

@liam-sbhoo liam-sbhoo merged commit c6aa666 into main Sep 20, 2024
2 checks passed
@liam-sbhoo liam-sbhoo deleted the remove-outdated-assertion-on-model-version branch September 20, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants