Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change taurus rpcs urls #141

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Change taurus rpcs urls #141

merged 1 commit into from
Oct 29, 2024

Conversation

marc-aurele-besner
Copy link
Member

@marc-aurele-besner marc-aurele-besner commented Oct 29, 2024

User description

Change taurus rpcs urls

  • Use Autonomys labs rpcs

PR Type

enhancement


Description

  • Updated the RPC URLs for the Taurus network in the network.ts file.
  • Added multiple WebSocket endpoints to improve connectivity and redundancy.

PRDescriptionHeader.CHANGES_WALKTHROUGH

Relevant files
Enhancement
network.ts
Update Taurus network RPC URLs with new endpoints               

packages/auto-utils/src/constants/network.ts

  • Updated RPC URLs for the Taurus network.
  • Added multiple new WebSocket endpoints for Taurus.
  • +5/-1     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    URL Validation
    Ensure that the new WebSocket URLs are correct and reachable. It's crucial to verify that these URLs do not lead to any downtime or connectivity issues.

    Copy link

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    Enhancement
    Add error handling or fallback for RPC URLs to enhance network reliability

    Consider adding a fallback mechanism or error handling for the RPC URLs to ensure
    connectivity even if one of the URLs fails.

    packages/auto-utils/src/constants/network.ts [33-37]

     rpcUrls: [
       'wss://rpc.taurus.subspace.network/ws',
       'wss://rpc-0.taurus.subspace.network/ws',
       'wss://rpc-1.taurus.subspace.network/ws',
    -],
    +], // Implement error handling or fallback mechanism here
    Suggestion importance[1-10]: 4

    Why: The suggestion to add error handling or a fallback mechanism for RPC URLs is valid and could improve network reliability. However, it lacks specific implementation details, making it less actionable and reducing its immediate impact.

    4

    @marc-aurele-besner marc-aurele-besner merged commit 07708e8 into main Oct 29, 2024
    2 checks passed
    @marc-aurele-besner marc-aurele-besner deleted the feat/change-taurus-rpcs branch October 29, 2024 19:40
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants