Fix AutoDrive Typings File #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc-aurele-besner
previously approved these changes
Dec 13, 2024
clostao
dismissed
marc-aurele-besner’s stale review
The base branch was changed.
marc-aurele-besner
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current types file doesn't point to a correct declaration file. Browser API is included in NodeJS's API so that's why it's used the
nodeone.This is not the best solution, I think that including a separate export into the
package.jsonwith/browseris the best to handle this. I'll implemente this with the update for enabling the user's not needingwebpackconfig.