Fix records encoding #3007
Merged
Fix records encoding #3007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some of the refactorings a check was done incorrectly in the plotting code that resulted in some sectors being plotted incorrectly.
The reason is that only one byte was checked even though the source was the result of XOR and it was possible for valid chunk to have all bits set in the last byte as well.
To smooth the impact of this I implemented scheduling of the sector for replotting when proving error is detected, such that farmer will slowly start fixing itself over time.
This issue was discovered as part of GPU plotting implementation when some of the plotting outputs were not matching expectations.
Code contributor checklist: