Modify MMR sync algorithm. #3025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We also need to modify MMR data processing later to address "five segments lag" ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies MMR-sync algorithm during its integration in the domain snap sync.
The main change is introducing the target block from which we sync the MMR data, we need this to reflect the fact that we synchronize only MMR data for finalized blocks and there is a lag between archived (accessible via snap-sync) and finalized blocks (MMR-data) in 5 segments of blocks. Additional change was improved error handling.
Relates to #3026
Code contributor checklist: