Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break things (part 1) #3033

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Break things (part 1) #3033

merged 2 commits into from
Sep 18, 2024

Conversation

nazar-pc
Copy link
Member

First cleanup PR that breaks compatibility with Gemini 3h and removes various workarounds needed in that context

Code contributor checklist:

teor2345
teor2345 approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Let me know if you want me to make the Blake3Hash and *Object breaking changes.

@nazar-pc
Copy link
Member Author

Sure, now is a good time to do all the breaking changes we need/want

@nazar-pc nazar-pc added this pull request to the merge queue Sep 18, 2024
Merged via the queue into main with commit c55c997 Sep 18, 2024
9 checks passed
@nazar-pc nazar-pc deleted the break-things-part-1 branch September 18, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teor2345 teor2345 teor2345 approved these changes

@shamil-gadelshin shamil-gadelshin Awaiting requested review from shamil-gadelshin

@NingLin-P NingLin-P Awaiting requested review from NingLin-P NingLin-P is a code owner

@rg3l3dr rg3l3dr Awaiting requested review from rg3l3dr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nazar-pc @teor2345