Upload gateway binary to artifacts and assets #3257
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 25, 2024
nazar-pc
reviewed
Nov 26, 2024
There was a problem hiding this comment.
Hm... isn't container image enough? We intentionally didn't upload bootstrap-node since most users will not need it and when they do they'll probably run a container image in production anyway. And even if someone really needs it, they can always extract files from container images or compile from source.
The list of files people see is already really long, so I'm reluctant to add more.
If this is really-really needed for some reason, we can upload it to build artifacts, but not release assets. I'm wondering what is the intended audience of this is, who can provide more details?
teor2345
force-pushed
the
gateway-docker
branch
from
0db2de7 to
222e853
Compare
teor2345
force-pushed
the
gateway-docker-upload
branch
from
233efaf to
765f808
Compare
|
I'm happy for you or Carlos to close this if it isn't needed. |
teor2345
force-pushed
the
gateway-docker-upload
branch
from
765f808 to
71c9387
Compare
|
Carlos has confirmed this isn’t needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
subspace-gatewayto the artifacts and assets of snapshot builds.@clostao when you asked for gateway binaries in CI, I'm guessing you wanted them to appear in snapshot build artifacts?
Test build here: https://github.com/autonomys/subspace/actions/runs/12022336058
Code contributor checklist: