Improve cluster plotter performance #3298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help with utilization of multiple GPUs. The theory here is that under certain conditions timeouts are preventing lower index sectors from making progress (order is not deterministic) and higher index sectors can't start because lower sector index are waiting for retry.
Notifying one of the pending sectors should allow to make progress faster and avoid leaving GPU idling. This may actually allow us to increase maximum time between retries now or even combine multiple concurrent retries into a single queue.
Waiting for community feedback on this before merging.
Code contributor checklist: