Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cluster piece getter #3345

Merged
merged 1 commit into from
Jan 14, 2025
+4 −1
Merged

Fix cluster piece getter #3345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/subspace-farmer/src/bin/subspace-farmer/commands/cluster/controller.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ pub(super) async fn controller(
);

let fut = farmer_cache_worker
.run(piece_getter.downgrade())
.run(piece_getter)
.instrument(info_span!("", %cache_group));

async move {
Expand Down
3 changes: 3 additions & 0 deletions crates/subspace-farmer/src/bin/subspace-farmer/commands/farm.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,6 +487,9 @@ where

let farmer_cache_worker_fut = run_future_in_dedicated_thread(
{
// Piece cache worker uses piece getter, while piece getter uses piece cache, which
// piece cache worker depends on. Use weak reference to break the cycle and allow worker
// to exit when last piece cache instance is dropped.
let future = farmer_cache_worker.run(piece_getter.downgrade());

move || future
Expand Down
Loading