-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cached index instead of GitHub API for recipe search #910
Open
homebysix
wants to merge
14
commits into
autopkg:dev
Choose a base branch
from
homebysix:dev_search_index2
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homebysix
changed the title
WIP: Use cached index instead of GitHub API for recipe search
Use cached index instead of GitHub API for recipe search
Feb 12, 2024
@nmcspadden I'm inclined to merge this to dev now, and finish up some of the rough edges (specifically what to do about |
Can you do a quick test on the dev_new_recipe_logic branch and see if it still works? If not, I'll take it and resolve the merges. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #862, and attempts to introduce a completely redesigned
autopkg search
capability based on parsing a precompiled search index rather than using GitHub's API to search for recipes dynamically. The index file is regenerated by GitHub Actions every 4 hours in this repo.This PR also includes a revised
print_gh_search_results()
function that creates the table spacing dynamically given a list of dictionaries containing table data.Example output
Basic search (cold cache)
Basic search (warm cache)
Search with no results
Search with >100 results
Search with specific user/org
Search paths only
TODO
Search keyword with major version
Search keyword without major version
Info search results find a single repo
Info search results find multiple repos
Unit tests
Search with no query
Path-only search
To do / help wanted
Consider these items before merging:
print_gh_search_results()
andget_search_results()
functionsGitHubSession.search_for_name()
functionget_repository_from_identifier()
function