feat: add configurable page load state #253
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucasAlvws
approved these changes
Aug 28, 2025
| return self._page_load_state | ||
|
|
||
| @page_load_state.setter | ||
| def page_load_state(self, state: PageLoadState): |
There was a problem hiding this comment.
maybe you could add a log warning the user if its setting interactive mode.
something like this: "Running code at 'interactive' state may cause issues — CSS, images, or external scripts might not be fully loaded yet."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PageLoadStateenum for document readinesspage_load_statevia Options and wait loopTesting
PYENV_VERSION=3.11.12 pytest tests/test_browser/test_browser_options.pyPYENV_VERSION=3.11.12 pytest(fails: No module named 'aioresponses')https://chatgpt.com/codex/tasks/task_e_68ab7795b1b083208903f71dbb55c70c