Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: more types #33

Merged
merged 1 commit into from
Jan 23, 2024
Merged

feat: more types #33

merged 1 commit into from
Jan 23, 2024

Conversation

meghein
Copy link
Contributor

@meghein meghein commented Jan 5, 2024 •
edited
Loading

Summary

  • Add more type declarations for plugin usage
  • Update error handling for failed template path

Test Plan

  • Install this branch as a dependency for any typescript project using fastify-mail, for instance fasdentify-v2
  • Build app and check for any type errors

HW13
HW13 approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@HW13 HW13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😎 👍

@meghein meghein changed the base branch from feat/dep-update to types January 23, 2024 18:54
@meghein meghein merged commit afb1363 into types Jan 23, 2024
1 check passed
@meghein meghein mentioned this pull request Jan 23, 2024
Merged
meghein added a commit that referenced this pull request Jan 23, 2024
@meghein
feat: more types (#33)
0125e2d
@meghein meghein mentioned this pull request Jan 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HW13 HW13 HW13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meghein @HW13