libvirt_vcpu_plug_unplug: adapt to s390x #6665
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S390x doesn't have ACPI (s3/s4), nor does it have cpu hot unplug. Set values and filter accordingly for s390x. Signed-off-by: Sebastian Mitterle <smitterl@redhat.com>
WalkthroughThis change modifies the libvirt virtual CPU plug/unplug test configuration file. It adds a new s390-virtio configuration section with specific settings that disable memory suspend, disk suspend, vCPU unplugging, and pin-before-unplug operations. Additionally, it removes an exclusionary "no s390-virtio" constraint from the pin_unplug variant within the vcpu_pin test path. These modifications alter test configuration constraints for the s390-virtio platform. Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
Contributor
Author
|
test log before I added |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
libvirt/tests/cfg/libvirt_vcpu_plug_unplug.cfg (1)
17-20: Consider explicitly filtering unplug-related variants for clarity and add documentation.The current approach disables vcpu_unplug and pin_before_unplug via parameter settings, which means unplug-related test variants (e.g.,
save_with_unplug,managedsave_with_unplug,suspend_with_unplug,pin_unplug,unplug_pin) will still be generated but won't perform actual unplug operations. This could be confusing and may result in redundant test runs that don't test meaningful functionality for s390x.Additionally, there's no documentation explaining the architectural limitations driving these changes.
Consider applying this more explicit approach:
s390-virtio: + # s390x lacks ACPI support (no s3/s4 suspend) and does not support CPU hot-unplug no suspend_to_mem, suspend_to_disk + no save_with_unplug, managedsave_with_unplug, suspend_with_unplug + no pin_unplug, unplug_pin vcpu_unplug = no - pin_before_unplug = noAlternatively, verify that the test implementation correctly handles vcpu_unplug="no" for these unplug-related variants and skips operations appropriately, ensuring the tests remain meaningful for s390-virtio.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
libvirt/tests/cfg/libvirt_vcpu_plug_unplug.cfg(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Python 3.12
- GitHub Check: Python 3.8
- GitHub Check: Python 3.11
- GitHub Check: Python 3.9
🔇 Additional comments (1)
libvirt/tests/cfg/libvirt_vcpu_plug_unplug.cfg (1)
66-70: Verify configuration precedence for pin_before_unplug on s390-virtio before merging.The
pin_unplugvariant explicitly setspin_before_unplug = "yes"(line 68), while the s390-virtio section setspin_before_unplug = no(line 20). The review notes indicate the explicitno s390-virtioexclusion was removed from this variant, meaning it now applies to s390-virtio platforms.The concern is valid: test code (line 436-439 in libvirt_vcpu_plug_unplug.py) has no architecture validation before executing pin operations. Verify that:
- The test framework's config precedence correctly applies architecture-level settings over nested variant settings, OR
- The pin operation gracefully fails/is-skipped on s390-virtio rather than causing test failures.
Note: All four pin variants (pin_plug_unplug, pin_unplug, plug_pin, unplug_pin) lack
no s390-virtioexclusion, suggesting this may be intentional framework behavior—but this should still be confirmed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
S390x doesn't have ACPI (s3/s4), nor does it have cpu hot unplug. Set values and filter accordingly for s390x.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.