Skip to content

Pathdet dataset curation roadwork dataset #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

docjag
Copy link
Contributor

@docjag docjag commented Jan 9, 2025

Hi @m-zain-khawaja I have add .gitignore file and a little change in the JSON file. I stored all the trajectory points for the drivable path as tuples rather than a list. Please feel free to have a look and provide your generous suggestions. Thank you.

@m-zain-khawaja
Copy link
Collaborator

m-zain-khawaja commented Jan 9, 2025

Change requests

  • Please can we use index numbers (e.g 00000.png, 00001.png, etc) instead of other filenames for the images in the drivable_path.json
  • Can we please crop the bottom of the image so that the car bonnet is removed, and can we please crop from the top of the image so that the final cropped image as a 2:1 (width:height) aspect ratio - please ensure that this is accounted for when storing the relative drivable path coordinates, i.e. (the new origin point (0,0) will be of the cropped image). One suggestion can be to use the start of the drivable path trajectory as visualized in the image as the bottom crop point. Please draw the visualization using normalized coordinates to ensure that the normalized coordinates are correct.

@docjag
Copy link
Contributor Author

docjag commented Jan 15, 2025

Completed all change requests and committed the final version.

Signed-off-by: Sohel Mahmud <sohel.digitalhive@gmail.com>
Signed-off-by: Sohel Mahmud <sohel.digitalhive@gmail.com>
Signed-off-by: Sohel Mahmud <sohel.digitalhive@gmail.com>
Signed-off-by: Sohel Mahmud <sohel.digitalhive@gmail.com>
Signed-off-by: Sohel Mahmud <sohel.digitalhive@gmail.com>
Signed-off-by: Sohel Mahmud <sohel.digitalhive@gmail.com>
Signed-off-by: Sohel Mahmud <sohel.digitalhive@gmail.com>
Copy link
Collaborator

@m-zain-khawaja m-zain-khawaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me - thanks @docjag

@m-zain-khawaja m-zain-khawaja merged commit dcc010a into autowarefoundation:pathdet-dataset-curation-roadwork-dataset Mar 1, 2025
1 check passed
@m-zain-khawaja
Copy link
Collaborator

@docjag - could you please pull the latest changes from the main branch because the folder structure has changed - we now have a EgoPath folder instead of a PathDet folder. Could you please move your files to the EgoPath folder, remove the old PathDet folder and then submit your PR again. I have reviewed your code changes and everything is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants