Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(tvm_utility) prefix package and namespace with autoware #9241

Closed
wants to merge 3 commits into from
Closed

refactor(tvm_utility) prefix package and namespace with autoware #9241

wants to merge 3 commits into from

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Nov 5, 2024

Description

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@esteve
refactor(tvm_utility) prefix package and namespace with autoware
92f255b 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve esteve added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 5, 2024
@esteve esteve enabled auto-merge (squash) November 5, 2024 14:53
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Nov 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

This was referenced Nov 5, 2024
Open
Open
pre-commit-ci bot and others added 2 commits November 5, 2024 14:56
@pre-commit-ci
style(pre-commit): autofix
6769c95
@esteve
update CODEOWNERS
1c3cd0d 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@github-actions github-actions bot added the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Nov 5, 2024
@ambroise-arm
Copy link
Contributor

Hi @esteve. This package was a dependency to the TVM packages, but they have all been removed from autoware.universe (#7701, #8175), and I am pretty sure no one uses this package anymore. You might want to remove it entirely instead of spending time maintaining it. But if we want to keep it then I am happy to review this PR, let me know.

@esteve esteve mentioned this pull request Nov 11, 2024
Merged
@esteve
Copy link
Contributor Author

esteve commented Nov 11, 2024

@ambroise-arm thanks for having a look. I'm closing this PR and just submitted #9291 which removes tvm_utility

@esteve esteve closed this Nov 11, 2024
auto-merge was automatically disabled November 11, 2024 12:39

Pull request was closed

@esteve esteve deleted the prefix-tvm_utility branch November 11, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambroise-arm ambroise-arm Awaiting requested review from ambroise-arm

Assignees
No one assigned
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@esteve @ambroise-arm