fix(docker): install CUDA development drivers in development containers #5332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
youtalk
changed the title
autoware:base image"
youtalk
added
type:containers
youtalk
changed the title
autoware:base image"Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
oguzkaganozt
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
arm64 build is failing with the error https://github.com/youtalk/autoware/actions/runs/11288252539/job/31395665979#step:6:612
Otherwise LGTM.
|
I hope it was self hosted runner problem. Please let me merge to run by GitHub runner. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolved #5219
The cause of #5219 is that due to the changes in #5159, only the CUDA runtime drivers are now being installed in both the development containers and the runtime containers. Though the development containers are required to install the CUDA development drivers.
https://github.com/autowarefoundation/autoware/blob/main/ansible/roles/cuda/tasks/main.yaml#L28-L50
This PR installs CUDA development drivers on development containers.
cc @marioney
Tests performed
https://github.com/youtalk/autoware/actions/runs/11288251647
https://github.com/youtalk/autoware/actions/runs/11288252539
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.