Skip to content

feat(docker): add vehicle/system launch files to autoware:universe-vehicle-system images #5588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 17, 2025

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Dec 19, 2024

Description

This PR makes it possible to run the autoware:universe-vehicle-system containers using the launch files designed for the components.

Ref. #5394

How was this PR tested?

Notes for reviewers

None.

Effects on system behavior

None.

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
@youtalk youtalk self-assigned this Dec 19, 2024
Copy link

github-actions bot commented Dec 19, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@youtalk youtalk added type:containers Docker containers, containerization of components, or container orchestration. component:openadkit Issues or Features related to Open AD Kit run:health-check Run health-check labels Dec 19, 2024
@youtalk youtalk requested review from xmfcx and mitsudome-r December 19, 2024 13:26
@youtalk
Copy link
Member Author

youtalk commented Dec 26, 2024

We need to resolve this first.

https://github.com/autowarefoundation/autoware/actions/runs/12413613640/job/34655898492?pr=5588#step:5:2264

#64 3.301 ERROR: no rosdep rule for 'autoware_vehicle_velocity_converter'

@mitsudome-r
Copy link
Member

Here's the command we can use for testing system.launch.

  1. Download and extract the necessary parameter files: system_config.zip

  2. Launch the system.launch.xml by the following command:

ros2 launch tier4_system_launch system.launch.xml \
  launch_system_monitor:="true" \
  launch_dummy_diag_publisher:="false" \
  sensor_model:="sample_sensor_kit" \
  component_state_monitor_topic_path:=system_config/component_state_monitor/topics.yaml \
  duplicated_node_checker_param_path:=$(ros2 pkg prefix --share duplicated_node_checker)/config/duplicated_node_checker.param.yaml \
  processing_time_checker_param_path:=$(ros2 pkg prefix --share autoware_processing_time_checker)/config/processing_time_checker.param.yaml \
  mrm_comfortable_stop_operator_param_path:=$(ros2 pkg prefix --share mrm_comfortable_stop_operator)/config/mrm_comfortable_stop_operator.param.yaml \
  mrm_emergency_stop_operator_param_path:=system_config/mrm_emergency_stop_operator/mrm_emergency_stop_operator.param.yaml \
  dummy_diag_publisher_param_path:=system_config/dummy_diag_publisher/dummy_diag_publisher.param.yaml \
  system_monitor_cpu_monitor_param_path:=$(ros2 pkg prefix --share system_monitor)/config/cpu_monitor.param.yaml \
  system_monitor_gpu_monitor_param_path:=$(ros2 pkg prefix --share system_monitor)/config/gpu_monitor.param.yaml \
  system_monitor_hdd_monitor_param_path:=$(ros2 pkg prefix --share system_monitor)/config/hdd_monitor.param.yaml \
  system_monitor_mem_monitor_param_path:=$(ros2 pkg prefix --share system_monitor)/config/mem_monitor.param.yaml \
  system_monitor_net_monitor_param_path:=$(ros2 pkg prefix --share system_monitor)/config/net_monitor.param.yaml \
  system_monitor_ntp_monitor_param_path:=$(ros2 pkg prefix --share system_monitor)/config/ntp_monitor.param.yaml \
  system_monitor_process_monitor_param_path:=$(ros2 pkg prefix --share system_monitor)/config/process_monitor.param.yaml \
  system_monitor_voltage_monitor_param_path:=$(ros2 pkg prefix --share system_monitor)/config/voltage_monitor.param.yaml \
  mrm_handler_param_path:=$(ros2 pkg prefix --share mrm_handler)/config/mrm_handler.param.yaml \
  diagnostic_graph_aggregator_param_path:=$(ros2 pkg prefix --share diagnostic_graph_aggregator)/config/default.param.yaml \
  diagnostic_graph_aggregator_graph_path:=system_config/diagnostic_graph_aggregator/autoware-main.yaml

@youtalk youtalk marked this pull request as draft March 12, 2025 13:32
@youtalk youtalk marked this pull request as ready for review March 16, 2025 23:55
@youtalk youtalk enabled auto-merge (squash) March 16, 2025 23:55
@youtalk youtalk merged commit 20f0617 into main Mar 17, 2025
17 of 18 checks passed
@youtalk youtalk deleted the feat/vs-launch branch March 17, 2025 01:13
@github-project-automation github-project-automation bot moved this from Execution to Done in Open AD Kit Working Group Mar 17, 2025
sykwer pushed a commit to sykwer/autoware that referenced this pull request Mar 22, 2025
…-vehicle-system` images (autowarefoundation#5588)

add vehicle & system launch

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: sykwer <sykwer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:openadkit Issues or Features related to Open AD Kit run:health-check Run health-check type:containers Docker containers, containerization of components, or container orchestration.
Projects
Development

Successfully merging this pull request may close these issues.

2 participants