Skip to content

feat(data_collecting_tool): improve data collection logic #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

YoshihiroKogure
Copy link
Contributor

@YoshihiroKogure YoshihiroKogure commented Sep 2, 2024

Description

  • The speed and acceleration data have been collected as evenly as possible on figure-eight course. ( Refer to the data on the heatmap and adjust the process to collect more data in areas where the data is lacking. Most of the data is collected on line parts of figure-eight course. )
  • Change figure-eight course slightly so that line parts becomes as large as possible in the rectangle section
  • Added the following two plots ( The right window in the image below )
    • Display the recent trajectory of velocity and acceleration ( The second one from the top )
    • data counts of velocity and steer on heatmap ( The fourth one from the top )
      ( The first one = velocity trajectory. The third one = data counts of velocity and acceleration on heatmap )

Screenshot from 2024-09-02 16-01-24

Related links

Tests performed

Notes for reviewers

Interface changes

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kosuke55 kosuke55 self-assigned this Sep 2, 2024
@YoshihiroKogure YoshihiroKogure changed the title create data collection logic feat(data_collecting_tool): add data collection logic Sep 2, 2024
@YoshihiroKogure YoshihiroKogure changed the title feat(data_collecting_tool): add data collection logic feat(data_collecting_tool): improve data collection logic Sep 2, 2024
@YoshihiroKogure YoshihiroKogure force-pushed the feat/improve-data-collection branch from 42c3b46 to fb7fd9a Compare September 4, 2024 07:26
@kosuke55
Copy link
Contributor

kosuke55 commented Sep 6, 2024

@YoshihiroKogure
thanks! works in my environment!

image

It is very heavy when plot

$ ros2 topic hz /data_collecting_trajectory
average rate: 2.257
        min: 0.219s max: 0.875s std dev: 0.30521s window: 3

please fix this issue in the future 🙏

Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
If the topic hz has a problem, it can still run. if it is disabled, the topic will not drop.

$ ros2 topic hz /data_collecting_trajectory
average rate: 31.630
        min: 0.020s max: 0.067s std dev: 0.00967s window: 33

YoshihiroKogure and others added 13 commits September 9, 2024 15:14
Signed-off-by: Yoshihiro Kogure <yoshihiro.kogure@proxima-ai-tech.com>
Signed-off-by: Yoshihiro Kogure <yoshihiro.kogure@proxima-ai-tech.com>
Signed-off-by: Yoshihiro Kogure <yoshihiro.kogure@proxima-ai-tech.com>
Signed-off-by: Yoshihiro Kogure <yoshihiro.kogure@proxima-ai-tech.com>
Signed-off-by: Yoshihiro Kogure <yoshihiro.kogure@proxima-ai-tech.com>
Signed-off-by: Yoshihiro Kogure <yoshihiro.kogure@proxima-ai-tech.com>
Signed-off-by: Yoshihiro Kogure <yoshihiro.kogure@proxima-ai-tech.com>
Signed-off-by: Yoshihiro Kogure <yoshihiro.kogure@proxima-ai-tech.com>
Signed-off-by: Yoshihiro Kogure <yoshihiro.kogure@proxima-ai-tech.com>
@YoshihiroKogure YoshihiroKogure force-pushed the feat/improve-data-collection branch from 318ed32 to ce431bd Compare September 9, 2024 06:16

self.on_line_vel_flag = True

self.previouse_target_vel = 2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
self.previouse_target_vel = 2.0
self.previous_target_vel = 2.0

Signed-off-by: Yoshihiro Kogure <yoshihiro.kogure@proxima-ai-tech.com>
@YoshihiroKogure YoshihiroKogure force-pushed the feat/improve-data-collection branch from c22bb9d to 22ef4f2 Compare September 9, 2024 10:41
@kosuke55 kosuke55 merged commit 75537a7 into autowarefoundation:main Sep 9, 2024
16 checks passed
@YoshihiroKogure YoshihiroKogure deleted the feat/improve-data-collection branch September 30, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants