-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lanelet2_map_validator): generation script for new validators #180
feat(lanelet2_map_validator): generation script for new validators #180
Conversation
Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ros2 run lanelet2_map_validator create_new.py <args>
is also good
Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #180 +/- ##
==========================================
+ Coverage 2.12% 38.40% +36.27%
==========================================
Files 163 27 -136
Lines 9402 638 -8764
Branches 383 379 -4
==========================================
+ Hits 200 245 +45
+ Misses 9045 178 -8867
- Partials 157 215 +58
☔ View full report in Codecov by Sentry. |
Description
This PR adds a tool to
autoware_lanelet2_map_validator
that can generate necessary files to create a new validator which will be useful to contributors.This PR does the following.
template
directory and add templates for documents and test codes.validator_template.cpp
andvalidator_template.hpp
totemplate
create_new_validator.py
that can generate necessary files for a new validator.create_new_validator.py
tohow_to_contribute.md
.How was this PR tested?
Tested the following command at the
autoware_tools/map/autoware_lanelet2_map_validator
directory, and checked four files are generated correctly.Then the output should be like
Notes for reviewers
None.
Effects on system behavior
None.