Fix gossip tests

ava-labs · May 4, 2024 · b5e872e · b5e872e
1 parent 63cead0
commit b5e872e
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 9 deletions.
diff --git a/network/p2p/gossip/gossip_test.go b/network/p2p/gossip/gossip_test.go
@@ -116,8 +116,9 @@ func TestGossiperGossip(t *testing.T) {
 				txs:   make(map[ids.ID]*testTx),
 				bloom: responseBloom,
 			}
-			for _, item := range tt.responder {
-				require.NoError(responseSet.Add(item))
+			errs := responseSet.Add(tt.responder...)
+			for _, err := range errs {
+				require.NoError(err)
 			}
 
 			metrics, err := NewMetrics(prometheus.NewRegistry(), "")
@@ -147,8 +148,9 @@ func TestGossiperGossip(t *testing.T) {
 				txs:   make(map[ids.ID]*testTx),
 				bloom: bloom,
 			}
-			for _, item := range tt.requester {
-				require.NoError(requestSet.Add(item))
+			errs = responseSet.Add(tt.responder...)
+			for _, err := range errs {
+				require.NoError(err)
 			}
 
 			requestClient := requestNetwork.NewClient(0x0)

diff --git a/vms/avm/network/gossip_test.go b/vms/avm/network/gossip_test.go
@@ -87,7 +87,7 @@ func TestGossipMempoolAdd(t *testing.T) {
 		TxID: ids.GenerateTestID(),
 	}
 
-	require.NoError(mempool.Add(tx))
+	require.NoError(mempool.Add(tx)[0])
 	require.True(mempool.bloom.Has(tx))
 }
 

diff --git a/vms/platformvm/network/gossip_test.go b/vms/platformvm/network/gossip_test.go
@@ -47,7 +47,7 @@ func TestGossipMempoolAddVerificationError(t *testing.T) {
 	)
 	require.NoError(err)
 
-	err = gossipMempool.Add(tx)
+	err = gossipMempool.Add(tx)[0]
 	require.ErrorIs(err, errFoo)
 	require.False(gossipMempool.bloom.Has(tx))
 }
@@ -81,7 +81,7 @@ func TestGossipMempoolAddError(t *testing.T) {
 	)
 	require.NoError(err)
 
-	err = gossipMempool.Add(tx)
+	err = gossipMempool.Add(tx)[0]
 	require.ErrorIs(err, errFoo)
 	require.False(gossipMempool.bloom.Has(tx))
 }
@@ -112,7 +112,7 @@ func TestMempoolDuplicate(t *testing.T) {
 	)
 	require.NoError(err)
 
-	err = gossipMempool.Add(tx)
+	err = gossipMempool.Add(tx)[0]
 	require.ErrorIs(err, mempool.ErrDuplicateTx)
 	require.False(gossipMempool.bloom.Has(tx))
 }
@@ -147,6 +147,6 @@ func TestGossipAddBloomFilter(t *testing.T) {
 	)
 	require.NoError(err)
 
-	require.NoError(gossipMempool.Add(tx))
+	require.NoError(gossipMempool.Add(tx)[0])
 	require.True(gossipMempool.bloom.Has(tx))
 }