merkledb -- verify range proof in fuzz test; fix bound error
#1789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlaine
changed the title
sync -- verify range proof in fuzz testsync -- verify range proof in fuzz test; fix bound error
dboehm-avalabs
approved these changes
Aug 2, 2023
danlaine
changed the title
sync -- verify range proof in fuzz test; fix bound errormerkledb -- verify range proof in fuzz test; fix bound error
|
I think this has been accomplished by #1793 except the fuzz test changes |
added 2 commits
August 8, 2023 11:06
…-labs/avalanchego into sync-verify-range-proof-in-fuzz-test
Yeah there's no longer any semantic change in this PR, just rewording, changing comments, etc. I'd be down to include these non-test changes, but fine either way. |
added 5 commits
August 8, 2023 11:47
…-labs/avalanchego into sync-verify-range-proof-in-fuzz-test
darioush
approved these changes
Aug 9, 2023
hexfusion
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
proof.go.How this works
Fixes how we handle upper bound in range proof verification. Previously, if a proof contained one key-value pair whose key was the root, we would set
largestPathto the empty path (""), causinginsertChildrenGreaterThanto beNothing. Then inaddPathInfowe would haveinsertChildrenGreaterThan == Nothing, meaning we would not add proof node children "on the right", resulting in an invalid root ID. See similar issue https://github.com/ava-labs/avalanchego/pull/1629/files#r1235447981.How this was tested
Added line in UT.