Dynamic Fees - Introducing fees calculators #2619
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abi87
requested review from
danlaine,
dhrubabasu and
StephenButtolph
as code owners
abi87
changed the title
abi87
commented
Jan 26, 2024
| @@ -137,7 +137,7 @@ func TestNewImportTx(t *testing.T) { | |||
| }, | |||
| ), | |||
| sourceKeys: []*secp256k1.PrivateKey{sourceKey}, | |||
| timestamp: env.config.BanffTime, | |||
There was a problem hiding this comment.
this does not make sense in the first place. We initialize the environment to to test Apricot fork
abi87
commented
Jan 29, 2024
vms/avm/txs/fees/calculator.go
Outdated
| type Calculator struct { | ||
| // setup, to be filled before visitor methods are called | ||
| Config *config.Config | ||
| ChainTime time.Time |
There was a problem hiding this comment.
while ChainTime is not strictly necessary here, we'll use it to check the active fork in next PRs. We keep ChainTime here so that we initialize it in this PR and we reduce diffs down the line
abi87
force-pushed
the
introducing-fees-calculators
branch
from
fe1e477
to
fcf8fc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Dynamic fees will require measuring size of txs, signatures and other txs components. We introduce feeCalculator visitors as a structure where dynamic fees calculations will be carried out.
How this works
Introduced fee calculators visitors for P-chain and X-chain.
How this was tested
CI