Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: Add test of platform.getValidatorsAt across nodes #2664

Merged
merged 4 commits into from
Jan 26, 2024

Conversation

marun
Copy link
Contributor

@marun marun commented Jan 24, 2024

No description provided.

@marun marun force-pushed the e2e-validator-sets branch 2 times, most recently from 2ecd951 to 283d564 Compare January 24, 2024 19:51
@marun marun marked this pull request as ready for review January 24, 2024 19:52
@marun marun self-assigned this Jan 24, 2024
@marun marun added the testing This primarily focuses on testing label Jan 24, 2024
@marun marun force-pushed the e2e-validator-sets branch 4 times, most recently from 9e2e6cc to ea3546f Compare January 24, 2024 20:11
tests/e2e/p/validator_sets.go Outdated Show resolved Hide resolved
tests/e2e/p/validator_sets.go Outdated Show resolved Hide resolved
tests/e2e/p/validator_sets.go Outdated Show resolved Hide resolved
Copy link
Contributor

@StephenButtolph StephenButtolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this nit this LGTM. Thanks for putting this up!

tests/e2e/p/validator_sets.go Outdated Show resolved Hide resolved
@StephenButtolph StephenButtolph added this to the v1.10.19 milestone Jan 26, 2024
@StephenButtolph StephenButtolph changed the title e2e: Add test of validatorsets across nodes e2e: Add test of platform.getValidatorsAt across nodes Jan 26, 2024
@StephenButtolph StephenButtolph added this pull request to the merge queue Jan 26, 2024
Merged via the queue into master with commit 39bb11f Jan 26, 2024
17 checks passed
@StephenButtolph StephenButtolph deleted the e2e-validator-sets branch January 26, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing This primarily focuses on testing
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

e2e: add check of validator set consistency at all heights for all nodes
3 participants