Refactor chains/manager
#2665
Closed
Refactor chains/manager
#2665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-kim
force-pushed
the
refactor-chain-creator
branch
10 times, most recently
from
e94ac03
to
8287633
Compare
joshua-kim
changed the title
chains/manager into platformvmchains/manager
| ProfileDir string | ||
| LogFactory logging.Factory | ||
| NodeConfig interface{} | ||
| Aliaser ids.Aliaser |
There was a problem hiding this comment.
Suggested change
| Aliaser ids.Aliaser | |
| ChainAliaser ids.Aliaser |
| lock sync.RWMutex | ||
| ipcs *ipcs.ChainIPCs | ||
| log logging.Logger | ||
| aliaser ids.Aliaser |
There was a problem hiding this comment.
Suggested change
| aliaser ids.Aliaser | |
| chainAliaser ids.AliaserReader |
api/info/service.go
Outdated
| @@ -40,7 +40,8 @@ type Info struct { | |||
| validators validators.Manager | |||
| myIP ips.DynamicIPPort | |||
| networking network.Network | |||
| chainManager chains.Manager | |||
| aliaser ids.Aliaser | |||
There was a problem hiding this comment.
Suggested change
| aliaser ids.Aliaser | |
| chainAliaser ids.AliaserReader |
| @@ -85,6 +84,7 @@ var ( | |||
| // Service defines the API calls that can be made to the platform chain | |||
| type Service struct { | |||
| vm *VM | |||
| aliaser ids.Aliaser | |||
There was a problem hiding this comment.
Suggested change
| aliaser ids.Aliaser | |
| chainAliaser ids.AliaserReader |
Comment on lines
97
to
107
| //TODO error | ||
| _ = e.ChainCreator.CreateChain( | ||
| txID, | ||
| tx.SubnetID, | ||
| tx.GenesisData, | ||
| tx.VMID, | ||
| tx.FxIDs, | ||
| ) |
There was a problem hiding this comment.
I'm not sure we want to error here. Currently we just log an error if creating a chain fails - rather than having the node FATAL... Bubbling the error here would cause the node to FATAL.
joshua-kim
force-pushed
the
refactor-chain-creator
branch
from
8287633
to
4d84fa4
Compare
|
This PR has become stale because it has been open for 30 days with no activity. Adding the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
How this works
How this was tested