-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SoV networking support #2951
Merged
Merged
SoV networking support #2951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
changed the title
Expose all validator sets to IP tracking
SoV networking support
Apr 18, 2024
marun
reviewed
Jun 18, 2024
marun
reviewed
Jun 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes LGTM. The test changes are so big though.
aaronbuchwald
approved these changes
Jun 25, 2024
marun
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Currently, the Avalanche network topology is a combination of strongly connected and a hub-spoke networks.
The Avalanche Primary Network validators form a strongly connected network. This enables Snow* consensus to rapidly confirm blocks.
Non-validators also connect to all Primary Network validators (but not other non-valdiators). This ends up looking like the Primary Network acting like the hub and all non-validators acting as spokes.
In order to connect to a Subnet, no additional connectivity logic is required because Subnet validators are required to also be Primary Network validators. This means that by just re-using the Primary Network's peer discovery, the Subnet will also have its own strongly connected validator hub and non-validator spokes.
However, ACP 13 and later ACP 77 suggest to remove the requirement that Subnet validators must also be Primary Network validators. In order to remove the restriction we must extend the peer discovery mechanism to understand Subnets.
How this works
The PR extends the IPs that Primary Network validators are tracking to include all Subnets. Subnets will utilize the Primary Network to bootstrap their connections.
When peers connect they already communicate the Subnets they are tracking. When a Primary Network validator is sent a
GetPeerList
message, they will respond to the request for IPs that are validators of Subnets that are tracked by the requester.How this was tested