Manually compact during bootstrapping iteration #3040
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
added
consensus
marun
approved these changes
May 22, 2024
dhrubabasu
approved these changes
May 22, 2024
abi87
reviewed
May 22, 2024
| @@ -206,8 +210,22 @@ func execute( | |||
| return err | |||
| } | |||
|
|
|||
| lastProcessedKey := iterator.Key() | |||
There was a problem hiding this comment.
nit: update comment on lines 200/201 to mention that we don't just reduce memory pressure but we also compact?
abi87
approved these changes
May 22, 2024
|
Closing in favor of #3045 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
When introducing the interval tree into bootstrapping, the database was designed to support iteration rather than random reads to improve querying performance. However, it appears that holding the the iterator prevents compaction from occurring in a timely manner. Over time (after executing > 1M blocks) the iteration starts to slow down significantly. By manually compacting the database periodically, we manage to avoid this slowdown.
How this works
Periodically calls
Compactevery 128 iterator releases.How this was tested
6h. Running master executed9.1Mof the blocks (out of13.7M) in30h 22m