Remove subnetIDs from uptime manager #3235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceyonur
commented
Jul 29, 2024
Comment on lines
+2444
to
+2450
| func (s *state) GetUptime(vdrID ids.NodeID) (time.Duration, time.Time, error) { | ||
| return s.validatorState.GetUptime(vdrID, constants.PrimaryNetworkID) | ||
| } | ||
|
|
||
| func (s *state) SetUptime(vdrID ids.NodeID, upDuration time.Duration, lastUpdated time.Time) error { | ||
| return s.validatorState.SetUptime(vdrID, constants.PrimaryNetworkID, upDuration, lastUpdated) | ||
| } |
There was a problem hiding this comment.
Intentionally added these here to not modify validator_metadata as we will probably modify it completely by also removing delegateeReward, potential reward etc
ceyonur
requested review from
abi87,
danlaine,
dhrubabasu,
StephenButtolph and
joshua-kim
as code owners
marun
reviewed
Jul 31, 2024
There was a problem hiding this comment.
Doc pointers on how a given VM is suggested to track uptime once this is removed? I didn't see mention in the merged version of ACP-77. I'm curious if each VM will have to implement something bespoke if there exists / we intend to provide (e.g. in subnet-evm or hypersdk) an easily configurable facility.
marun
reviewed
Aug 1, 2024
marun
reviewed
Aug 1, 2024
marun
reviewed
Aug 1, 2024
darioush
reviewed
Aug 5, 2024
Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org> Signed-off-by: Ceyhun Onur <ceyhunonur54@gmail.com>
Signed-off-by: Ceyhun Onur <ceyhun.onur@avalabs.org>
Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org> Signed-off-by: Ceyhun Onur <ceyhunonur54@gmail.com>
darioush
approved these changes
Aug 9, 2024
StephenButtolph
approved these changes
Sep 23, 2024
StephenButtolph
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
With ACP-77, P-chain will not track uptimes; instead every VM should be tracking their own uptimes for their subnets. This removes any subnetID related uptime tracking logic from AvalancheGo/P-chain.
Should be merged after #3226 gets in a release
How this works
ConnectedSubnetinternal messageSubnetUptimesand it's handling in p2p ping messageHow this was tested