Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unsafe blake3 benchmark for merkledb #3350

Draft
wants to merge 1 commit into
base: add-blake3-benchmark
Choose a base branch
from
Draft

Add unsafe blake3 benchmark for merkledb #3350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 19 additions & 8 deletions x/merkledb/hashing.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,11 @@ const HashLength = 32

var (
SHA256Hasher Hasher = &sha256Hasher{}
BLAKE3Hasher Hasher = &blake3Hasher{}
// This hasher is not safe to use as it is not thread safe. However, it is
// useful to show the performance difference between SHA256 and BLAKE3.
BLAKE3Hasher Hasher = &blake3Hasher{
blake: blake3.New(),
}

// If a Hasher isn't specified, this package defaults to using the
// [SHA256Hasher].
Expand Down Expand Up @@ -95,16 +99,16 @@ func (*sha256Hasher) HashValue(value []byte) ids.ID {
return sha256.Sum256(value)
}

// TODO: If the hasher were not used concurrently, we could reset the internal
// state for a significant performance improvement.
type blake3Hasher struct{}
type blake3Hasher struct {
blake *blake3.Hasher
}

// This method is performance critical. It is not expected to perform any memory
// allocations.
func (*blake3Hasher) HashNode(n *node) ids.ID {
func (b *blake3Hasher) HashNode(n *node) ids.ID {
var (
// blake.Write always returns nil, so we ignore its return values.
blake = blake3.New()
blake = b.blake
hash ids.ID
// The hash length is larger than the maximum Uvarint length. This
// ensures binary.AppendUvarint doesn't perform any memory allocations.
Expand Down Expand Up @@ -151,11 +155,18 @@ func (*blake3Hasher) HashNode(n *node) ids.ID {
_, _ = blake.Write(binary.AppendUvarint(emptyHashBuffer, uint64(n.key.length)))
_, _ = blake.Write(n.key.Bytes())
blake.Sum(emptyHashBuffer)
blake.Reset()
return hash
}

// This method is performance critical. It is not expected to perform any memory
// allocations.
func (*blake3Hasher) HashValue(value []byte) ids.ID {
return blake3.Sum256(value)
func (b *blake3Hasher) HashValue(value []byte) ids.ID {
// blake.Write always returns nil, so we ignore its return values.
_, _ = b.blake.Write(value)

var hash ids.ID
b.blake.Sum(hash[:0])
b.blake.Reset()
return hash
}
Loading