Implement ACP-77 validator state #3388
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
commented
Sep 16, 2024
vms/platformvm/state/diff.go
Outdated
| return d.parentActiveSOVs + d.sovDiff.numAddedActive | ||
| } | ||
|
|
||
| func (d *diff) NumSubnetOnlyValidators(subnetID ids.ID) (int, error) { |
There was a problem hiding this comment.
This should return the weight rather than the count.
StephenButtolph
commented
Sep 17, 2024
Comment on lines
+1844
to
+1848
| // Load inactive weights | ||
| it := s.weightsDB.NewIterator() | ||
| defer it.Release() | ||
|
|
||
| for it.Next() { |
There was a problem hiding this comment.
We should only be loading subnets with at least one active validator.
StephenButtolph
commented
Sep 17, 2024
| @@ -2004,6 +2172,303 @@ func (s *state) writeExpiry() error { | |||
| return nil | |||
| } | |||
|
|
|||
| // TODO: Update validator sets | |||
| // TODO: Add caching | |||
| func (s *state) writeSubnetOnlyValidators(updateValidators bool, height uint64) error { | |||
There was a problem hiding this comment.
Note: this only works if the nodeIDs written here are unrelated to legacy subnet validators. This is fairly reasonable because we're going to be introducing 32-byte nodeIDs for SoVs.
…ov-validators-state
StephenButtolph
changed the base branch from
master
to
remove-subnetid-uptime-manager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
How this works
How this was tested