Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update sdk names #10

Merged
merged 6 commits into from
Aug 1, 2024
Merged

chore: update sdk names #10

merged 6 commits into from
Aug 1, 2024

Conversation

meeh0w
Copy link
Member

@meeh0w meeh0w commented Jul 31, 2024

Description

Changes

  • Update names of SDKs

TODOs

  • Release & update SDKs versions when CI succeeds

Testing

  • Log out of NPM in the console npm logout, or rename your ~/.npmrc file.
  • Verify you're logged out by calling npm whoami - it should show an error message
  • Remove node_modules and do a clean install of dependencies
  • Run yarn dev and perform a sanity check. There should be no functional or visual changes at all.

Screenshots

Checklist for the author

  • I've covered new/modified business logic with Jest test cases.
  • I've tested the changes myself before sending it to code review and QA.

@ryanml
Copy link
Contributor

ryanml commented Jul 31, 2024

lgtm, just needs a lint fix and i can approve

bferenc
bferenc previously approved these changes Aug 1, 2024
Copy link
Contributor

@bferenc bferenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@vvava vvava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍚

@meeh0w meeh0w merged commit 0e95bdc into main Aug 1, 2024
4 of 5 checks passed
@meeh0w meeh0w deleted the chore/update-sdk-names branch August 1, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants